-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BatchedMesh: add getColorAt and setColorAt #28255
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth updating the batched mesh example to show color rendering, as well.
For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to create a new example similar to the raycasting one for BatchedMesh to not mess with the existing one ("mesh / batch")?
cc @Mugen87 do you think an example update is needed at all?
Not necessarily. |
Sounds good to me, then. Once the other couple comments are addressed I think this is ready |
Following the discussion at #28151, I'm creating this PR to add per-instance
get/setColorAt()
forBatchedMesh
.I took special care in doing it in a way similar to how
setColorAt()
is implemented forInstancedMesh
so no additional computation happens in the shaders in case no color is ever set.