-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New Docs: Updated templates with old design. #32002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Mugen87 I'm seeing a lot of repetition about what the methods return: ![]() Is this intended? |
I guess there's also a bug where JSDoc assumes a method is (nullable) because it can return |
In the default template, there is type information in the signature and the types are mentioned in the descriptive text. That should be as excepted. |
I understand that technically it's expected. But I don't think it's ideal to have all that duplication in the docs. Do you known how/where can we fix it? |
I guess the way to solve is by removing all these redundant descriptions? /**
* Returns the current set filter.
*
* @return {?AudioNode} The filter.
*/
getFilter() {
return this.filter;
} If so, I can make the AI do it. |
I would recommend to keep the JSDoc markup standard and update the template instead. It should be possible to update the template such that method signatures document no return types. Meaning everything behind the three.js/utils/docs/template/publish.js Line 189 in cbc975b
|
I'm not sure we are talking about the same thing. Could you elaborate? |
Okay, I'll give it a go next Monday. There's still quite a bit of work to do for replacing the old docs. I'll push the release until they're ready. |
Related issue: #30748
Description
Trying to get JSDoc to produce a design more similar to what we had.
For comparison: https://threejs.org/docs/?q=icosahedron#api/en/geometries/IcosahedronGeometry