Examples: Fix Firefox Error in "webgl_interactive_cubes_gpu" #8604
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in
webgl_interactive_cubes_gpu
logged by Firefox 45.0.1.The problem is that the example can generate read requests with
readRenderTargetPixels
that contain out-of-bounds pixels (see FF source code for more information). To avoid this problem, an additionalif
statement prevents read request with mouse coordinates less or equal zero.A more strict implementation could be done in
readRenderTargetPixels
. The method could only allow read request withx
andy
values within the range of [1,renderTarget.width
] and [1,renderTarget.height
].