This repository was archived by the owner on Sep 14, 2023. It is now read-only.
Merged
Conversation
Owner
|
Super elegant. Thanks for that! 🎉 |
Owner
|
Ehehe, we hit a compiler bug: Pretty sure reintegrating master does the trick, as pyo3 0.5 support has landed now. |
Collaborator
Author
|
This compiler bug was the reason I had released 0.5 in the first place. I'm still not done with the breaking changes I wanted for that release (PyToken is done now, specialization still has some instances) I've reported the bug at rust-lang/rust#55380. |
Owner
|
Sorry about the |
Collaborator
Author
|
It's required for the test suite, so I've just silenced the warning ¯\_(ツ)_/¯ |
mre
approved these changes
Nov 14, 2018
Owner
|
Thanks! 💰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the new style that people should use.
CI won't pass until the 0.5 branch is merged.