"RangeError: Maximum call stack size exceeded" when using `followRelationshipsData`

[s1nz]

Hi Matthew!

I'm getting the "RangeError: Maximum call stack size exceeded" error when trying to do:

      this.$store
        .dispatch('jv/get', [
          `products/similar_products`,
          {
            params: {
              magentoProductId: this.product._id,
              include: 'supplier'
            }
          }
        ])

JSON response from server

{
  "links": {
    "self": "/api/products/similar_products?magentoProductId=1\u0026include=supplier"
  },
  "meta": { "totalItems": 28 },
  "data": [
    {
      "id": "6201",
      "type": "Product",
      "attributes": {
        "_id": 6201,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-07-04T13:24:44+00:00",
        "createdAt": "2018-04-09T10:14:11+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "112" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "18737",
      "type": "Product",
      "attributes": {
        "_id": 18737,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": false,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-01-08T14:55:49+00:00",
        "createdAt": "2018-04-10T07:07:13+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "34" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "20884",
      "type": "Product",
      "attributes": {
        "_id": 20884,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": false,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2018-04-10T09:23:33+00:00",
        "createdAt": "2018-04-10T08:44:37+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "65" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "40642",
      "type": "Product",
      "attributes": {
        "_id": 40642,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": false,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-06-05T14:57:48+00:00",
        "createdAt": "2018-08-27T07:26:55+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "154" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "42685",
      "type": "Product",
      "attributes": {
        "_id": 42685,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-07-10T07:28:52+00:00",
        "createdAt": "2018-09-04T07:45:23+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "155" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "32089",
      "type": "Product",
      "attributes": {
        "_id": 32089,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-04-15T16:16:27+00:00",
        "createdAt": "2018-04-11T13:25:38+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "126" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "2528",
      "type": "Product",
      "attributes": {
        "_id": 2528,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-07-04T13:58:21+00:00",
        "createdAt": "2018-04-09T09:23:35+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "21" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "19782",
      "type": "Product",
      "attributes": {
        "_id": 19782,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-06-25T07:27:42+00:00",
        "createdAt": "2018-04-10T07:24:54+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "133" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "37062",
      "type": "Product",
      "attributes": {
        "_id": 37062,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2018-06-04T16:28:19+00:00",
        "createdAt": "2018-06-04T16:28:19+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "100" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "56377",
      "type": "Product",
      "attributes": {
        "_id": 56377,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-05-22T14:39:51+00:00",
        "createdAt": "2019-05-22T14:39:51+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "178" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "11602",
      "type": "Product",
      "attributes": {
        "_id": 11602,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-04-15T14:34:59+00:00",
        "createdAt": "2018-04-09T15:13:28+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "63" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "51495",
      "type": "Product",
      "attributes": {
        "_id": 51495,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-07-04T14:15:23+00:00",
        "createdAt": "2019-04-15T15:06:52+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "9" } },
        "magentoProducts": {
          "data": [{ "type": "MagentoProduct", "id": "1558" }]
        }
      }
    },
    {
      "id": "14539",
      "type": "Product",
      "attributes": {
        "_id": 14539,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-06-25T07:28:23+00:00",
        "createdAt": "2018-04-09T15:57:05+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "102" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "54266",
      "type": "Product",
      "attributes": {
        "_id": 54266,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-05-22T14:05:37+00:00",
        "createdAt": "2019-05-22T13:41:39+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "175" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "50962",
      "type": "Product",
      "attributes": {
        "_id": 50962,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": false,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-07-04T13:24:40+00:00",
        "createdAt": "2019-04-15T14:53:43+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "112" } }
      }
    },
    {
      "id": "6480",
      "type": "Product",
      "attributes": {
        "_id": 6480,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-07-04T13:24:44+00:00",
        "createdAt": "2018-04-09T10:14:11+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "112" } }
      }
    },
    {
      "id": "18374",
      "type": "Product",
      "attributes": {
        "_id": 18374,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": false,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2018-05-03T12:10:22+00:00",
        "createdAt": "2018-04-10T07:07:13+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "34" } },
        "magentoProducts": {
          "data": [{ "type": "MagentoProduct", "id": "1506" }]
        }
      }
    },
    {
      "id": "25649",
      "type": "Product",
      "attributes": {
        "_id": 25649,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-07-04T14:15:23+00:00",
        "createdAt": "2018-04-10T14:23:51+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "9" } }
      }
    },
    {
      "id": "51376",
      "type": "Product",
      "attributes": {
        "_id": 51376,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": false,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-06-05T14:57:48+00:00",
        "createdAt": "2019-04-15T15:03:57+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "154" } }
      }
    },
    {
      "id": "58028",
      "type": "Product",
      "attributes": {
        "_id": 58028,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-07-10T07:28:52+00:00",
        "createdAt": "2019-06-11T12:57:31+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "155" } }
      }
    },
    {
      "id": "51771",
      "type": "Product",
      "attributes": {
        "_id": 51771,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-06-25T07:28:41+00:00",
        "createdAt": "2019-04-15T15:23:23+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "102" } },
        "magentoProducts": {
          "data": [{ "type": "MagentoProduct", "id": "1558" }]
        }
      }
    },
    {
      "id": "37813",
      "type": "Product",
      "attributes": {
        "_id": 37813,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-06-25T07:28:24+00:00",
        "createdAt": "2018-06-05T13:39:53+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "102" } }
      }
    },
    {
      "id": "52327",
      "type": "Product",
      "attributes": {
        "_id": 52327,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-06-25T07:29:00+00:00",
        "createdAt": "2019-04-15T16:05:41+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "33" } }
      }
    },
    {
      "id": "56321",
      "type": "Product",
      "attributes": {
        "_id": 56321,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-05-22T14:39:51+00:00",
        "createdAt": "2019-05-22T14:39:51+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "178" } },
        "magentoProducts": {
          "data": [{ "type": "MagentoProduct", "id": "2915" }]
        }
      }
    },
    {
      "id": "4003",
      "type": "Product",
      "attributes": {
        "_id": 4003,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-07-05T07:20:21+00:00",
        "createdAt": "2018-04-09T09:58:23+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "4" } },
        "magentoProducts": { "data": [{ "type": "MagentoProduct", "id": "1" }] }
      }
    },
    {
      "id": "58403",
      "type": "Product",
      "attributes": {
        "_id": 58403,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "CHF",
        "baseCurrency": "EUR",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-07-05T07:20:21+00:00",
        "createdAt": "2019-07-05T07:20:21+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "4" } }
      }
    },
    {
      "id": "22244",
      "type": "Product",
      "attributes": {
        "_id": 22244,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": false,
        "isVermouth": false,
        "hasMatches": true,
        "updatedAt": "2019-04-15T16:05:21+00:00",
        "createdAt": "2018-04-10T13:39:12+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "33" } },
        "magentoProducts": {
          "data": [{ "type": "MagentoProduct", "id": "2915" }]
        }
      }
    },
    {
      "id": "57859",
      "type": "Product",
      "attributes": {
        "_id": 57859,
        "sku": "111111",
        "name": "name",
        "alcohol": 40,
        "size": 70,
        "price": 10,
        "basePrice": 12,
        "currency": "",
        "baseCurrency": "",
        "isInStock": true,
        "isVermouth": false,
        "hasMatches": false,
        "updatedAt": "2019-06-25T07:29:07+00:00",
        "createdAt": "2019-06-05T14:33:58+00:00"
      },
      "relationships": {
        "supplier": { "data": { "type": "Supplier", "id": "33" } }
      }
    }
  ],
  "included": [
    {
      "id": "112",
      "type": "Supplier",
      "attributes": {
        "_id": 112,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:30+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "34",
      "type": "Supplier",
      "attributes": {
        "_id": 34,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:22+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "65",
      "type": "Supplier",
      "attributes": {
        "_id": 65,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:25+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "154",
      "type": "Supplier",
      "attributes": {
        "_id": 154,
        "code": "code",
        "name": "name",
        "createdAt": "2018-08-27T06:51:52+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "155",
      "type": "Supplier",
      "attributes": {
        "_id": 155,
        "code": "code",
        "name": "name",
        "createdAt": "2018-09-04T06:57:40+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "126",
      "type": "Supplier",
      "attributes": {
        "_id": 126,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:31+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "21",
      "type": "Supplier",
      "attributes": {
        "_id": 21,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:20+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "133",
      "type": "Supplier",
      "attributes": {
        "_id": 133,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-10T07:16:58+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "100",
      "type": "Supplier",
      "attributes": {
        "_id": 100,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:29+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "178",
      "type": "Supplier",
      "attributes": {
        "_id": 178,
        "code": "code",
        "name": "name",
        "createdAt": "2019-05-21T18:09:29+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "63",
      "type": "Supplier",
      "attributes": {
        "_id": 63,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:25+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "9",
      "type": "Supplier",
      "attributes": {
        "_id": 9,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:19+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "102",
      "type": "Supplier",
      "attributes": {
        "_id": 102,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:29+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "175",
      "type": "Supplier",
      "attributes": {
        "_id": 175,
        "code": "code",
        "name": "name",
        "createdAt": "2019-05-21T18:06:47+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "33",
      "type": "Supplier",
      "attributes": {
        "_id": 33,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:22+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    },
    {
      "id": "4",
      "type": "Supplier",
      "attributes": {
        "_id": 4,
        "code": "code",
        "name": "name",
        "createdAt": "2018-04-06T08:58:19+00:00",
        "isDomestic": false,
        "currency": "EUR"
      }
    }
  ]
}

Any idea what is happening?

[mrichar1]

Without digging through the JSON, this kind of problem is usually caused by recursion in your data somewhere - i.e. a chain of relationships that eventually points back to the original item.

Depending on how you walk the data, jsonapi-vuex can hit the recursion (memory) limits in javascript.

The most common way that this is triggered is via the builtin JSON library (which is also what vue uses to display objects in templates. to avoid this, jsonapi-vuex uses the special toJSON() method to return a simplified relationship that prevents recursion (just type and id).

I'd be interested to know what you are doing with the results of the action - i.e what is in the then for this dispatch - since that will be where the recursion is being triggered - and I can suggest ways to work around this.

[s1nz]

Thanks for the quick reply. Yep, looks like you are right, the error is triggered only when I'm trying to render the results of the action. I'm currently trying to use https://github.com/vueComponent/ant-design-vue/blob/master/components/table/Table.jsx. The error is triggered only when I'm trying to use rowSelection param(https://vue.ant.design/components/table/#rowSelection).

[mrichar1]

OK - it looks like it is walking the whole object and hitting the recursion. As a quick test of this, can you try doing:

this.$store
  .dispatch('jv/get', [
    `products/similar_products`,
    {
      params: {
        magentoProductId: this.product._id,
        include: 'supplier'
      }
    }
  ])
  .then((res) => {
    res = JSON.parse(JSON.stringify(res))
  })

This should turn the object to JSON and back, causing the recursion to be 'pruned'. You can then pass res on to the table widget.

If this works then it's apparent that there are other uses where data walking is needed, other than JSON - and I'll need to think about how to remove recursion in these cases.

[s1nz]

Yep, that seems to be working! Thank you

[mrichar1]

OK - that's good - it's a small inefficiency to 'JSON and back' the data, so I'll look at a way of get-ing the data without the recursion for more general use.

[stefanvanherwijnen]

I'm having a similar problem with getRelated. I think an easy fix is:

const checkAndFollowRelationships = (state, getters, records) => {
  if (jvConfig.followRelationshipsData) {
    let resData = {}
    if (jvtag in records) {
      // single item
      resData = followRelationships(state, getters, records).toJSON()
    } else {
      // multiple items
      for (let [key, item] of Object.entries(records)) {
        resData[key] = followRelationships(state, getters, item).toJSON()
      }
    }
    if (resData) {
      return resData
    }
  }
  return records
}

That is, adding toJSON() to the relationships retrieved by checkAndFollowRelationships(). If I am correct, this should stop the recursion at the first relationship. This obviously prevents following a relationship tree, but I don't think there is an easy way to detect if the relationship tree ends up at the root object again somewhere (i.e. recursion).

[mrichar1]

Thanks for reminding me of this.

Yes, toJSON is too specific to solve all use cases where recursion happens.

I have a solution worked out in my head where, if enabled via a config option, recursive branches will be 'pruned' - giving a result similar to what toJSON returns, but for all cases.

I'm aiming to pick this up again next week - hopefully the JSON parse/stringify hack will suffice for now...

[mrichar1]

I think that's a general-purpose fix for this issue now in pr #89 - basically it gives the same end-result as toJSON did, but isn't specific to the JSON methods.

I've left it configurable so that recursion can be enabled if that is the preferred use.

Any comments/code review appreciated! I'm hoping to merge this soon.

[stefanvanherwijnen]

In my case I still get a recursion error on cloneDeep():
https://github.com/mrichar1/jsonapi-vuex/blob/master/src/jsonapi-vuex.js#L576

I'm looking into it now, but it seems that followRelationships() is still repeatedly called, not sure why.

    reactiveGetter VueJS
    Lodash 16
        baseClone
        arrayEach
        baseClone
        baseClone
        arrayEach
        baseClone
        baseClone
        arrayEach
        baseClone
        baseClone
        arrayEach
        baseClone
        baseClone
        arrayEach
        baseClone
        cloneDeep
    followRelationships jsonapi-vuex.js:576
    checkAndFollowRelationships jsonapi-vuex.js:559
    get jsonapi-vuex.js:383
    get jsonapi-vuex.js:613
    Lodash 107
        createBaseFor
        baseMerge
        baseMergeDeep
        ...
client-prefetch.js:94

I think seenState is always undefined?

Edit: If I understand it correctly from the tests, seenState should be an argument for the getter? Could you clarify on how to properly use this new functionality, because I am a bit lost 😬

Edit2: Seems my problem is fixed by adding a default value for seenState at line 362 (the getter).

[mrichar1]

Thanks for reporting that and for spotting the solution! This is an accidental regression on my part - there did used to get a default variable, but it got deleted somewhere...

The getters that get added by followRelationships track what relationships they've already seen in the seenState object. Since this (js) getter goes on to call the (vuex) get getter it has to pass seenState 'round the loop' so that all subsequent getters can track the state.

There are 2 ways to 'get in' to this code - via the action get or the getter get (which both call checkAndFollowRelationships). If you look at the action get you'll see it calls checkAndFollowRelationships with no seenState argument (which means it should be falling back to a default value (of {}) but this isn't the case. This should have thrown TypeError (undefined != {}) - but since I'm using .getand.set` these both mask such errors.

I think the correct place to set this default value is in checkAndFollowRelationships - I'm not in front of my usual computer to code up a fix - but if you're happy to try it out, can you change the function definition to:

const checkAndFollowRelationships = (state, getters, records, seenState = {}) => {

EDIT: Just pushed 2.2.1 which should have a fix for this. Let me know if that fixes things? Thanks!