🐛 Settings window opens itself "randomly"

[hoelderlin]

Bug Description

Sometimes, when using mac OS or any app, the configuration window of the app opens itself randomly.

Steps To Reproduce

I can replicate it by: 1. go to "About this mac" in the apple logo icon in the menu bar and 2. close it with the Command+W keyboard shortcut

Expected Behavior

It should just close the window of the app I'm using

Actual Behavior

It closes the app window I'm using but at the same time it opens the settings menu.

Screenshots

No response

MacOS Version

Sonoma 14.3

Loop Version

Version 1.0.0-beta.14 (644)

Additional Context

No response

Final Checks

• My issue title is descriptive
• This is a single bug (multiple bugs should be reported individually)

[mrkai77]

I am unable to reproduce this bug on my computer :(
Would you be able to send a screen recording after having had quitted and relaunched Loop?

[hoelderlin]

Hi here's a video. The quality is low but I think you'll get it. This also happens when quit apps.
After restaring the app the issue is gone. But this is the second time it happened to me.

screen_rec.mov

[mrkai77]

Thanks!
That's really weird behavior!
Loop currently only opens the settings window if it becomes the active app. I suspect that this is happening because Loop is becoming the "last active app" when all other windows are closed?
I'll have to dig deeper and try and find the root cause though.

[hoelderlin]

I have these custom key-bindings. Not sure if it might be casuing this.

[tlgnkl]

the same problem :(

[just-doit]

May be implementing applicationShouldHandleReopen in the app delegate like this would work:

    func applicationShouldHandleReopen(_ sender: NSApplication, hasVisibleWindows flag: Bool) -> Bool {
        self.openSettings()
        return false
    }

Instead of

    func applicationWillBecomeActive(_ notification: Notification) {
        guard canOpenSettings else { return }
        self.openSettings()
    }

You may want to change applicationDidFinishLaunching like this, to open settings when the app is launched but not as login item:

        if !self.launchedAsLoginItem {
            self.openSettings()
        }

[mrkai77]

@just-doit Great point! I've never used applicationShouldHandleReopen before but it might fix the problem!

Does this build with the above changes fix this issue? (I can't test it since I could never reproduce the bug)
Loop.zip

[yougotwill]

I have this bug every time I start up. Using the test build now and will report back.

[yougotwill]

So far so good!