Skip to content

🐞 Reduce drag event overhead#1011

Merged
mrkai77 merged 1 commit into
mrkai77:developfrom
manuthebyte:develop
Jan 21, 2026
Merged

🐞 Reduce drag event overhead#1011
mrkai77 merged 1 commit into
mrkai77:developfrom
manuthebyte:develop

Conversation

@manuthebyte
Copy link
Copy Markdown
Contributor

#1001

tldr

  • Prevents global drag monitoring from doing work unless snapping/restore/stash features are active.
  • Stops repeated window-resolution attempts during non-window drags (e.g., games).
  • Resets drag state on mouse up to avoid stale drag tracking.

Tests

  • I have run my tests on my NMS instance, works as expected now and doesn't bug anymore.

Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and it makes sense that this would cause lag. Thank you!

Comment thread Loop/Core/WindowDragManager.swift
@mrkai77 mrkai77 merged commit 96efb5e into mrkai77:develop Jan 21, 2026
1 check passed
@mrkai77 mrkai77 added the Bug label Jan 21, 2026
@mrkai77 mrkai77 linked an issue Jan 21, 2026 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Loop ≥1.4 lags and sometimes holds inputs hostage in Minecraft

2 participants