✨ Use privileged updater helper if needed#1063
Merged
Merged
Conversation
…horization in backup pruning
prevents TOCTOU attack
SenpaiHunters
requested changes
Mar 5, 2026
Collaborator
SenpaiHunters
left a comment
There was a problem hiding this comment.
Remember to also include the README updates 😄.
If we're fine overall with the try? log, then it can be accepted as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch started as a fix for updater failures in non-admin sessions, but it ended up being a full updater hardening pass!
The main change is a new privileged helper,
LoopUpdaterHelper, that Loop can use during update installation when the current user session cannot write to the install location. Previously, this could cause the update to fail outright.Security was a huge focus here. The helper is intentionally strict:
Installation flow changes in Loop:
UpdaterAuthorizationCoordinatorto manage privileged readiness, Authorization Services rights, one-shotSMJobSubmit, helper calls, timeout handling, andSMJobRemovecleanup.writable,needsElevation,notWritableNoElevationPossible) so install behavior is explicit.~/Applicationsinstead of hard-failing.Backup/rollback/indexing behavior changes:
LoopSupportPaths.~/Library/Application Support/Loop.Rollback.noindexto avoid Spotlight/app-launcher indexing..zipbackups after swap..zip,Performance and reliability improvements:
codesignto Security framework APIs.FileManagerextension and reused where needed.