✨ Use NSDockTilePlugIn to customize icon#1075
Merged
Merged
Conversation
6 tasks
mrkai77
changed the title
SenpaiHunters
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
NSDockTilePlugInto manage Loop's Dock icon, replacing the previous approach of only settingNSApp.applicationIconImage. This is the more "normal" way for an app to change its dock icon, and matches the implementation of other apps such as Arc.Changes
IconManagerupdates: When the icon changes, a distributed notification is posted so the dock plugin can react immediately. After setting the icon, the Dock's icon cache is deleted (best-effort) andSLSIconAppearanceConfigurationis re-saved to force the Dock to re-read the bundle's.iconfile (reference!)Icon.isDefaultcomputed property replaces the oldIcon.defaultstatic with a cleaner check againstCFBundleIconName.