Skip to content

Add SettingTab enum type#290

Merged
mrkai77 merged 4 commits into
mrkai77:developfrom
phlpsong:tab-enum
Mar 29, 2024
Merged

Add SettingTab enum type#290
mrkai77 merged 4 commits into
mrkai77:developfrom
phlpsong:tab-enum

Conversation

@phlpsong
Copy link
Copy Markdown
Contributor

Define an enum SettingTab to replace the current hardcode tab index

Comment thread Loop/Settings/SettingsView.swift Outdated
Comment thread Loop/Settings/SettingsView.swift Outdated
Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@mrkai77 mrkai77 merged commit 7965a29 into mrkai77:develop Mar 29, 2024
@phlpsong phlpsong deleted the tab-enum branch March 30, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants