🐞 Fix window moving off-screen#567
Merged
Merged
Conversation
This commit fixes windows being moved off-screen via the keyboard shortcut when padding and animation are enabled. The bug was caused by applying padding to a zero sized screenFrame. The bounds check in the animation would then fail.
Owner
|
Thank you! Is the comment have written here also something you plan to fix in this PR, or is this ready for review? |
Contributor
Author
|
This is ready for review. |
mrkai77
approved these changes
Sep 26, 2024
Owner
mrkai77
left a comment
mrkai77
left a comment
There was a problem hiding this comment.
Looks good and makes sense, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes windows being moved off-screen via the keyboard shortcut when padding and animation are enabled.
The bug was caused by applying padding to a zero sized screenFrame. The bounds check in the animation would then fail.
Further explanation here.