🐞 Fix crash when hiding or minimizing windows#576
Merged
mrkai77 merged 2 commits intoSep 28, 2024
Merged
Conversation
4 tasks
SenpaiHunters
previously approved these changes
Sep 27, 2024
Collaborator
SenpaiHunters
left a comment
SenpaiHunters
left a comment
There was a problem hiding this comment.
I forgot about loop being able to do this, anyway push her to prod!
…-or-hiding-an-app-with-an-keybind` # Conflicts: # Loop/Window Management/WindowAction.swift
mrkai77
deleted the
mrkai77/loop-636-crash-when-minimizing-or-hiding-an-app-with-an-keybind
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where Loop would crash when trying to minimize or hide a window. This is because there is no "frame" for Loop to calculate (even though it was trying to get one) when it was trying to calculate a target frame.