✨ Add horizontal/vertical center half#577
Merged
Merged
Conversation
Owner
|
Hey @ShawnZhong, thanks for the PR, it looks great! When you're ready for us to take a look, please request a review :) |
Contributor
Author
|
This PR is ready for review. Please let me know if anything can be improved. |
mrkai77
requested changes
Oct 1, 2024
Closed
mrkai77
approved these changes
Oct 1, 2024
Owner
mrkai77
left a comment
mrkai77
left a comment
There was a problem hiding this comment.
Just tested locally, works great :)
Thank you so much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for horizontal/vertical center half:
This matches center half in Recangle:
https://github.com/rxhanson/Rectangle/blob/309359b0e884580b45d64ea09def09e00e48b9e8/Rectangle/WindowAction.swift#L178
I have never contributed to any Swift/ObjC projects before. Please let me know if there are any things I missed.