Skip to content

🐞 Fix cycle actions not working#595

Merged
mrkai77 merged 1 commit into
developfrom
mrkai77/loop-647-allow-the-window-position-commands-to-move-to-next-screen
Oct 15, 2024
Merged

🐞 Fix cycle actions not working#595
mrkai77 merged 1 commit into
developfrom
mrkai77/loop-647-allow-the-window-position-commands-to-move-to-next-screen

Conversation

@mrkai77
Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 commented Oct 14, 2024

Not sure how I didn't catch this bug earlier :/

This fixes a bug where cycle keybinds stop advancing after switching screens. Please test before approving, since again, I find it really odd that this bug originally even made it to production.

@mrkai77 mrkai77 self-assigned this Oct 14, 2024
@mrkai77 mrkai77 requested a review from SenpaiHunters October 14, 2024 20:48
@ShawnZhong
Copy link
Copy Markdown
Contributor

I encountered this exact issue previously as well! I ultimately removed the screen switching from the Left/Right cycles. Will test if it is now working with this PR.

@ShawnZhong
Copy link
Copy Markdown
Contributor

Just tested that the issue is reproducible on 1.2.0 (1356) and fixed by this PR.

@mrkai77
Copy link
Copy Markdown
Owner Author

mrkai77 commented Oct 15, 2024

@ShawnZhong awesome thank you so much for testing!!

@mrkai77 mrkai77 merged commit 2aa63c6 into develop Oct 15, 2024
@mrkai77 mrkai77 deleted the mrkai77/loop-647-allow-the-window-position-commands-to-move-to-next-screen branch October 15, 2024 23:12
@mrkai77 mrkai77 added the Bug label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants