💫 Improve window animations#667
Merged
Merged
Conversation
- Use the current refresh rate of the current display for `.frameRate`. - Reduce the strain on the accessibility framework by never setting the same `position` or `size` twice. This should help reduce any redundant computation that might occur when the animation happens. - Use `round` on `newFrame` so that we don't try and render frames with subpixel precision and make the compare statements work as intended.
Contributor
Author
|
Don't know if this is just me, but it does feel "smoother" with these changes. Could just be all in my head :) Please take it for a spin to verify that the changes work as intended. I'm running them locally now. |
mrkai77
approved these changes
Jan 10, 2025
Owner
mrkai77
left a comment
mrkai77
left a comment
There was a problem hiding this comment.
Tested locally, works well! I also moved the display mode code into the NSScreen+Extensions file. While I didn’t notice a visible difference, this is a good improvement as it also potentially reduces unnecessary refreshes and resizes. Thank you! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.frameRate.positionorsizetwice. This should help reduce any redundant computation that might occur when the animation happens.roundonnewFrameso that we don't try and render frames with subpixel precision and make the compare statements work as intended.