✨ UI Rewrite for new version of Luminare#703
Merged
Merged
Conversation
4 tasks
# Conflicts: # Loop.xcodeproj/project.pbxproj # Loop/Luminare/Loop/AdvancedConfiguration.swift # Loop/Utilities/WallpaperProcessor.swift
4 tasks
# Conflicts: # Loop.xcodeproj/project.pbxproj # Loop/Luminare/Settings/Keybindings/KeybindsConfigurationView.swift
# Conflicts: # Loop.xcodeproj/project.pbxproj
# Conflicts: # Loop/Luminare/Settings/Behavior/BehaviorConfiguration.swift # Loop/Luminare/Settings/Keybindings/KeybindItemView.swift
4 tasks
SenpaiHunters
previously requested changes
Jul 14, 2025
Collaborator
SenpaiHunters
left a comment
SenpaiHunters
left a comment
There was a problem hiding this comment.
Hey, I reviewed the PR. There are a few things and crashes to fix; after that, we're good to merge!
Otherwise, there is a memory leak. Also see: https://github.com/lwouis/alt-tab-macos/blob/b325cc75c02ea6685e9adef93e49a8a1700062fb/src/api-wrappers/CGWindowID.swift#L21
SenpaiHunters
previously approved these changes
Jul 27, 2025
Collaborator
SenpaiHunters
left a comment
SenpaiHunters
left a comment
There was a problem hiding this comment.
I think one last thing we should do before squash merging this to main would be to fix the Swift format errors in the linting. After that, I think we're good to release.
mrkai77
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch of Loop aims to rewrite the UI to fully support the new version of Luminare, which will be merged in the near future. This includes performance improvements, logical improvements and new UI features :)
On top of that, I have also taken advantage of this opportunity to improve the overall structure of Loop's settings UI architecture, which now directly uses
Defaults's@Defaultproperty wrapper when available. This will ensure that the new UI is more reactive to certain settings the user may change. Furthermore, icons have been renamed, and the Xcode project now uses folders instead of groups.cc @KrLite, who inspired and helped the process of rewriting of Luminare :)