Skip to content

✨ General improvements#737

Merged
SenpaiHunters merged 7 commits into
developfrom
general-improvements
May 30, 2025
Merged

✨ General improvements#737
SenpaiHunters merged 7 commits into
developfrom
general-improvements

Conversation

@mrkai77
Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 commented May 30, 2025

No description provided.

@mrkai77 mrkai77 self-assigned this May 30, 2025
@mrkai77 mrkai77 linked an issue May 30, 2025 that may be closed by this pull request
4 tasks
@mrkai77 mrkai77 force-pushed the general-improvements branch from 8217162 to a0982b8 Compare May 30, 2025 20:09
@mrkai77 mrkai77 force-pushed the general-improvements branch from 2be3934 to 0dd841a Compare May 30, 2025 22:04
@mrkai77 mrkai77 requested a review from Copilot May 30, 2025 22:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces general improvements across the codebase including refinements to window action handling, enhanced documentation and code readability, and updated keybind and preview window behaviors.

  • Updated window engine logic to store the most recent live frame when the preview is not visible.
  • Refactored and expanded the WindowAction API with additional documentation and a new method for comparing window manipulation actions.
  • Introduced a new PreviewStartingPosition enum and updated related settings and keybind views.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Loop/Window Management/WindowEngine.swift Adds logic to update the last target frame when preview is hidden.
Loop/Window Management/WindowAction.swift Refactors initializers and methods, adds detailed documentation, and introduces isSameManipulation.
Loop/Preview Window/PreviewStartingPosition.swift Adds new enum for preview window starting positions.
Loop/Preview Window/PreviewController.swift Updates preview window logic to adjust starting positions and transparency.
Loop/Managers/LoopManager.swift Adjusts access control for initialMousePosition and refines action comparison logic.
Loop/Luminare/Settings/Keybindings/KeybindItemView.swift Simplifies duplicate keybind count using updated syntax.
Loop/Luminare/Settings/Keybindings/CycleBackwardsView.swift Updates text for improved user clarity on cycling actions.
Loop/Localizable.xcstrings Updates localized strings to match new messaging.
Loop/Extensions/Defaults+Extensions.swift Enhances default keys documentation and updates cycle action definitions.
Loop.xcodeproj/project.pbxproj Adds references for the new PreviewStartingPosition.swift file.
Comments suppressed due to low confidence (1)

Loop/Window Management/WindowAction.swift:119

  • [nitpick] Consider explicitly binding the optional property (e.g., 'if let cycle = action.cycle') to enhance code clarity for those less familiar with the new Swift shorthand syntax.
if let cycle {

@mrkai77 mrkai77 requested a review from SenpaiHunters May 30, 2025 22:17
@SenpaiHunters SenpaiHunters merged commit 41ec0ce into develop May 30, 2025
1 check passed
@SenpaiHunters SenpaiHunters deleted the general-improvements branch May 30, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants