✨ General improvements#737
Merged
Merged
Conversation
4 tasks
This was
linked to
issues
May 30, 2025
8217162 to
a0982b8
Compare
2be3934 to
0dd841a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces general improvements across the codebase including refinements to window action handling, enhanced documentation and code readability, and updated keybind and preview window behaviors.
- Updated window engine logic to store the most recent live frame when the preview is not visible.
- Refactored and expanded the WindowAction API with additional documentation and a new method for comparing window manipulation actions.
- Introduced a new PreviewStartingPosition enum and updated related settings and keybind views.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Loop/Window Management/WindowEngine.swift | Adds logic to update the last target frame when preview is hidden. |
| Loop/Window Management/WindowAction.swift | Refactors initializers and methods, adds detailed documentation, and introduces isSameManipulation. |
| Loop/Preview Window/PreviewStartingPosition.swift | Adds new enum for preview window starting positions. |
| Loop/Preview Window/PreviewController.swift | Updates preview window logic to adjust starting positions and transparency. |
| Loop/Managers/LoopManager.swift | Adjusts access control for initialMousePosition and refines action comparison logic. |
| Loop/Luminare/Settings/Keybindings/KeybindItemView.swift | Simplifies duplicate keybind count using updated syntax. |
| Loop/Luminare/Settings/Keybindings/CycleBackwardsView.swift | Updates text for improved user clarity on cycling actions. |
| Loop/Localizable.xcstrings | Updates localized strings to match new messaging. |
| Loop/Extensions/Defaults+Extensions.swift | Enhances default keys documentation and updates cycle action definitions. |
| Loop.xcodeproj/project.pbxproj | Adds references for the new PreviewStartingPosition.swift file. |
Comments suppressed due to low confidence (1)
Loop/Window Management/WindowAction.swift:119
- [nitpick] Consider explicitly binding the optional property (e.g., 'if let cycle = action.cycle') to enhance code clarity for those less familiar with the new Swift shorthand syntax.
if let cycle {
SenpaiHunters
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.