✨ Small fixes#770
Merged
Merged
Conversation
Owner
mrkai77
commented
Jul 28, 2025
- Dims "Request" button instead of whole "accessibility access" row when granted
- Fixes small flicker when LuminarePopup window closes
- Updater buttons are full-width once again
4 tasks
4 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR implements several UI improvements and fixes across the application. The changes focus on fixing visual glitches, improving accessibility UI patterns, and adding low power mode detection.
- Replaces timer-based accessibility checking with proper async tracking
- Adds low power mode awareness to prevent window animations when power saving is enabled
- Updates UI components to use consistent styling patterns and padding values
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| WindowEngine.swift | Adds low power mode check to prevent window operations when power saving is active |
| VisualEffectView.swift | Simplifies state assignment using shorthand syntax |
| UpdateView.swift | Updates button styling to use full-width layout and newer style syntax |
| LoopManager.swift | Adds explicit type annotation and improves action handling logic |
| PreviewConfiguration.swift | Increases popover padding for better visual spacing |
| KeybindsConfigurationView.swift | Updates padding and replaces deprecated tint usage |
| KeybindItemView.swift | Standardizes popover padding and tint color implementation |
| CustomActionConfigurationView.swift | Increases popover padding for consistency |
| PaddingConfigurationView.swift | Updates popover padding to match design system |
| BehaviorConfiguration.swift | Standardizes popover padding across components |
| AdvancedConfiguration.swift | Major refactor replacing timer-based checking with async tracking and adding low power mode support |
| Localizable.xcstrings | Adds localization string for low power mode warning |
| Defaults+Extensions.swift | Adds configuration option for ignoring low power mode |
| project.pbxproj | Updates Luminare package reference |
Comments suppressed due to low confidence (1)
Loop/Managers/LoopManager.swift:407
- The closing brace for the else block is missing proper indentation or placement. The else block starting at line 405 should have a matching closing brace, but the structure appears incomplete.
}
SenpaiHunters
approved these changes
Jul 28, 2025
Collaborator
SenpaiHunters
left a comment
There was a problem hiding this comment.
I accept the review, but I do ask you to add
Task {
await WallpaperProcessor.fetchLatestWallpaperColors()
}to the window WindowDragManager.swift so we can update #768.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.