Skip to content

✨ Small fixes#770

Merged
mrkai77 merged 9 commits into
developfrom
small-fixes
Jul 29, 2025
Merged

✨ Small fixes#770
mrkai77 merged 9 commits into
developfrom
small-fixes

Conversation

@mrkai77
Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 commented Jul 28, 2025

  • Dims "Request" button instead of whole "accessibility access" row when granted
  • Fixes small flicker when LuminarePopup window closes
  • Updater buttons are full-width once again

@mrkai77 mrkai77 self-assigned this Jul 28, 2025
@mrkai77 mrkai77 linked an issue Jul 28, 2025 that may be closed by this pull request
@mrkai77 mrkai77 linked an issue Jul 28, 2025 that may be closed by this pull request
4 tasks
@mrkai77 mrkai77 requested a review from Copilot July 28, 2025 21:38
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements several UI improvements and fixes across the application. The changes focus on fixing visual glitches, improving accessibility UI patterns, and adding low power mode detection.

  • Replaces timer-based accessibility checking with proper async tracking
  • Adds low power mode awareness to prevent window animations when power saving is enabled
  • Updates UI components to use consistent styling patterns and padding values

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
WindowEngine.swift Adds low power mode check to prevent window operations when power saving is active
VisualEffectView.swift Simplifies state assignment using shorthand syntax
UpdateView.swift Updates button styling to use full-width layout and newer style syntax
LoopManager.swift Adds explicit type annotation and improves action handling logic
PreviewConfiguration.swift Increases popover padding for better visual spacing
KeybindsConfigurationView.swift Updates padding and replaces deprecated tint usage
KeybindItemView.swift Standardizes popover padding and tint color implementation
CustomActionConfigurationView.swift Increases popover padding for consistency
PaddingConfigurationView.swift Updates popover padding to match design system
BehaviorConfiguration.swift Standardizes popover padding across components
AdvancedConfiguration.swift Major refactor replacing timer-based checking with async tracking and adding low power mode support
Localizable.xcstrings Adds localization string for low power mode warning
Defaults+Extensions.swift Adds configuration option for ignoring low power mode
project.pbxproj Updates Luminare package reference
Comments suppressed due to low confidence (1)

Loop/Managers/LoopManager.swift:407

  • The closing brace for the else block is missing proper indentation or placement. The else block starting at line 405 should have a matching closing brace, but the structure appears incomplete.
            }

Comment thread Loop.xcodeproj/project.pbxproj
@mrkai77 mrkai77 requested a review from SenpaiHunters July 28, 2025 21:42
Copy link
Copy Markdown
Collaborator

@SenpaiHunters SenpaiHunters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accept the review, but I do ask you to add

Task {
     await WallpaperProcessor.fetchLatestWallpaperColors()
    }

to the window WindowDragManager.swift so we can update #768.

@mrkai77 mrkai77 linked an issue Jul 29, 2025 that may be closed by this pull request
4 tasks
@mrkai77 mrkai77 merged commit 3a041c6 into develop Jul 29, 2025
1 check passed
@mrkai77 mrkai77 deleted the small-fixes branch July 29, 2025 20:24
@mrkai77 mrkai77 changed the title Small fixes ✨ Small fixes Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants