Skip to content

✨ Add a "Minimize others" action#797

Merged
mrkai77 merged 7 commits into
mrkai77:developfrom
cipher-shad0w:issue_772
Sep 6, 2025
Merged

✨ Add a "Minimize others" action#797
mrkai77 merged 7 commits into
mrkai77:developfrom
cipher-shad0w:issue_772

Conversation

@cipher-shad0w
Copy link
Copy Markdown
Contributor

@cipher-shad0w cipher-shad0w commented Aug 26, 2025

Fixes #772

I have one issue. When I press the shortcut for the 'minimizeOther' action, there is a window snapping preview appears in the top left corner. I don't know where it comes from.

Do you have any ideas or tips on how to fix this?

Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review! I have requested a few changes. I am currently unable to reproduce the bug you mentioned in your comment, saying how a preview window shows up. Otherwise, this seems good!

Comment thread Loop/Window Management/WindowAction+Image.swift Outdated
Comment thread Loop/Window Management/WindowDirection.swift Outdated
@mrkai77 mrkai77 added the Feature label Sep 6, 2025
Copy link
Copy Markdown
Contributor Author

@cipher-shad0w cipher-shad0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the bug just now either. I think it's been fixed

Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits 😅

Comment thread Loop/Window Management/WindowDirection.swift Outdated
Comment thread Loop/Window Management/WindowEngine.swift Outdated
@cipher-shad0w
Copy link
Copy Markdown
Contributor Author

Oh, auto replace was not the best idea here 😅

Comment thread Loop/Window Management/WindowEngine.swift Outdated
@mrkai77 mrkai77 merged commit abf1986 into mrkai77:develop Sep 6, 2025
@cipher-shad0w cipher-shad0w deleted the issue_772 branch September 10, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Add a "Minimize others" action

2 participants