Skip to content

✨ Modularization of trigger key detection, system window manager bug fixes#798

Merged
SenpaiHunters merged 10 commits into
developfrom
modularization-and-bug-fixes
Aug 31, 2025
Merged

✨ Modularization of trigger key detection, system window manager bug fixes#798
SenpaiHunters merged 10 commits into
developfrom
modularization-and-bug-fixes

Conversation

@mrkai77
Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 commented Aug 29, 2025

No description provided.

@mrkai77 mrkai77 self-assigned this Aug 29, 2025
@mrkai77 mrkai77 linked an issue Aug 29, 2025 that may be closed by this pull request
2 tasks
@mrkai77 mrkai77 requested a review from Copilot August 29, 2025 20:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the trigger key detection system into modular observers, implements system window manager integration, and transitions several singletons to the shared pattern. The refactoring separates trigger key and middle-click detection logic into dedicated observer classes while maintaining the same functionality.

Key Changes:

  • Modularized trigger key detection into dedicated observer classes
  • Integrated system window manager padding settings dynamically
  • Migrated multiple manager classes to the singleton pattern with shared instances

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Loop/Managers/Triggers/TriggerKeyObserver.swift New dedicated class for observing trigger key events
Loop/Managers/Triggers/MiddleClickObserver.swift New dedicated class for observing middle-click events
Loop/Utilities/PaddingSettings.swift New utility for dynamic padding settings based on system window manager
Loop/Utilities/ScreenUtility.swift Renamed from ScreenManager to ScreenUtility with visibility improvements
Loop/Managers/SystemWindowManager.swift Removed syncPadding method and improved padding property implementation
Loop/Managers/LoopManager.swift Refactored to use new trigger observers and shared instances
Loop/Window Management/WindowEngine.swift Updated to use PaddingSettings and ScreenUtility
Loop/AppDelegate.swift Simplified to use shared instances instead of static properties

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Loop/Utilities/PaddingSettings.swift
Comment thread Loop/Managers/SystemWindowManager.swift
Repository owner deleted a comment from Copilot AI Aug 29, 2025
@mrkai77 mrkai77 requested a review from SenpaiHunters August 29, 2025 20:40
@mrkai77 mrkai77 marked this pull request as ready for review August 29, 2025 20:42
Copy link
Copy Markdown
Collaborator

@SenpaiHunters SenpaiHunters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally for a while and reviewed the code. I can't see, feel, or notice any major issues between the new and old versions, so I'll accept this PR into the main.

@SenpaiHunters SenpaiHunters merged commit 3d8456a into develop Aug 31, 2025
1 check passed
@SenpaiHunters SenpaiHunters deleted the modularization-and-bug-fixes branch August 31, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Apply Trigger Delay to Middle-click

3 participants