Skip to content

🐞 Do not swallow mid-click down event#848

Merged
mrkai77 merged 1 commit into
mrkai77:developfrom
totoroyyb:develop
Oct 11, 2025
Merged

🐞 Do not swallow mid-click down event#848
mrkai77 merged 1 commit into
mrkai77:developfrom
totoroyyb:develop

Conversation

@totoroyyb
Copy link
Copy Markdown
Contributor

Problem

The current implementation of handling mid-click is to completely ignore the mid-click down event. This is undesired in many cases. For example, mid-click (up+down) is often used in a browser to quickly close a tab. Loop currently completely swallows such mouse events so that mid-click won't work correctly in these cases.

Modifications

The patch here is simple.

  1. Return the mid-click down event as usual.
  2. Cancel the trigger delay timer if there is any. In this case (when the delay timer is not nil), it means the user releases the mouse mid-button before the delay, so we should cancel the timer.

@mrkai77 mrkai77 merged commit f1cb0da into mrkai77:develop Oct 11, 2025
1 check passed
@mrkai77 mrkai77 self-requested a review October 11, 2025 03:16
@mrkai77
Copy link
Copy Markdown
Owner

mrkai77 commented Oct 11, 2025

Thanks :)

@mrkai77 mrkai77 added the Bug label Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants