Skip to content

🐞 Restore trigger delay and double click functionality#860

Merged
mrkai77 merged 4 commits into
developfrom
restore-trigger-delay-and-double-click
Oct 29, 2025
Merged

🐞 Restore trigger delay and double click functionality#860
mrkai77 merged 4 commits into
developfrom
restore-trigger-delay-and-double-click

Conversation

@mrkai77
Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 commented Oct 28, 2025

No description provided.

@mrkai77 mrkai77 self-assigned this Oct 28, 2025
@mrkai77 mrkai77 added the Bug label Oct 28, 2025
@mrkai77 mrkai77 requested a review from Copilot October 28, 2025 03:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores trigger delay and double-click functionality to the Loop window manager by refactoring the trigger mechanism architecture. The changes extract shared timing logic into reusable utility classes and update observers to support both features consistently.

Key changes:

  • Introduced TriggerDelayTimer and DoubleClickTimer helper classes to centralize timing logic
  • Updated MiddleClickObserver and KeybindObserver to use the new timer utilities
  • Modified callback signatures to accept WindowAction? and Bool parameters for more flexible control

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Loop/Core/Triggers/MiddleClickObserver.swift Refactored to use new timer helpers and updated callbacks to support WindowAction and forceClose parameters
Loop/Core/Triggers/KeybindObserver.swift Extracted trigger delay logic to TriggerDelayTimer, added double-click support, and introduced helper methods for opening/closing loop
Loop/Core/Triggers/Helpers/TriggerDelayTimer.swift New utility class that manages trigger delay timers with support for action updates
Loop/Core/Triggers/Helpers/DoubleClickTimer.swift New utility class that detects double-click events within the system interval
Loop/Core/LoopManager.swift Updated middle-click observer callback to pass forceClose parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Loop/Core/Triggers/KeybindObserver.swift Outdated
@mrkai77 mrkai77 merged commit 606b57e into develop Oct 29, 2025
1 check passed
@mrkai77 mrkai77 deleted the restore-trigger-delay-and-double-click branch October 29, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants