🐞 Restore trigger delay and double click functionality#860
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR restores trigger delay and double-click functionality to the Loop window manager by refactoring the trigger mechanism architecture. The changes extract shared timing logic into reusable utility classes and update observers to support both features consistently.
Key changes:
- Introduced
TriggerDelayTimerandDoubleClickTimerhelper classes to centralize timing logic - Updated
MiddleClickObserverandKeybindObserverto use the new timer utilities - Modified callback signatures to accept
WindowAction?andBoolparameters for more flexible control
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Loop/Core/Triggers/MiddleClickObserver.swift | Refactored to use new timer helpers and updated callbacks to support WindowAction and forceClose parameters |
| Loop/Core/Triggers/KeybindObserver.swift | Extracted trigger delay logic to TriggerDelayTimer, added double-click support, and introduced helper methods for opening/closing loop |
| Loop/Core/Triggers/Helpers/TriggerDelayTimer.swift | New utility class that manages trigger delay timers with support for action updates |
| Loop/Core/Triggers/Helpers/DoubleClickTimer.swift | New utility class that detects double-click events within the system interval |
| Loop/Core/LoopManager.swift | Updated middle-click observer callback to pass forceClose parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.