✨ Add proportional window sizing for screen transitions#861
✨ Add proportional window sizing for screen transitions#861cipher-shad0w wants to merge 4 commits into
Conversation
|
This implementation applies proportional sizing only to standard window positions (halves, quarters, What's supported ✅
What's NOT supported ❌
Technical reasoning The feature checks for action.direction.frameMultiplyValues != nil to determine if proportional sizing |
|
This is a really good attempt at tackling the issue, thank you so much for taking the time to dive into it! Unfortunately, the approach isn’t quite correct. The main sign that this method isn’t ideal is that the preview window would no longer accurately reflect the frame of the window on the new screen. Action frames shouldn’t be calculated inside WindowEngine; its role should focus on executing them instead. The correct approach would be to calculate the proportional frame within While reviewing this PR, I ended up putting together my own solution for the issue, which I’ll be merging (#874). I’d encourage you to take a look at it, I’d be more than happy to walk you through any of the changes if you’d like! Once again, I really appreciate your effort and initiative here. It means a lot that you took the time to work on this :) |
Closes #713
Implements proportional window sizing when moving windows between displays of different sizes. Previously, windows would retain their absolute pixel dimensions
when transitioning between screens, leading to inconsistent behavior. This PR introduces screen-aware calculations that maintain window proportions relative to
each display's dimensions.