✨ Ability to use window corner radius in preview + SkyLightToolBelt & SkyLightSymbolLoader#906
Merged
Merged
Conversation
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR refactors and enhances window corner radius handling in preview windows by consolidating SkyLight API interactions and adding dynamic loading capabilities for private APIs.
- Centralizes SkyLight API interactions into a dedicated
SkyLightToolBeltand addsSkyLightSymbolLoaderfor runtime symbol resolution - Enables preview windows to use the actual corner radius of selected windows
- Refactors logging to use
descriptioninstead ofdebugDescriptionwhere appropriate
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Loop/Stashing/StashManager.swift | Updated logging calls to use description instead of debugDescription for Window objects |
| Loop/Localizable.xcstrings | Added localization strings for corner radius configuration options and bumped version to 1.1 |
| Loop/Extensions/RectangleCornerRadii+Extensions.swift | New extension providing inset method for adjusting corner radii with minimum radius constraint |
| Loop/Extensions/Defaults+Extensions.swift | Added previewUseWindowCornerRadius user default to toggle between window-specific and default corner radius |
| Loop/Extensions/AXUIElement+Extensions.swift | Updated function name from _AXUIElementGetWindow to AXUIElementGetWindow to match declaration in PrivateApis.swift |
| Loop/Core/WindowDragManager.swift | Updated logging to use description for Window objects |
| Loop/Core/LoopManager.swift | Refactored window handling to delay targetWindow assignment, improved isLoopActive flag management, and updated logging to use description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SenpaiHunters
approved these changes
Nov 27, 2025
Collaborator
SenpaiHunters
left a comment
There was a problem hiding this comment.
This finally compiles for macOS 15, testing locally. Hopefully, when built with actions, we don't see any errors or crashes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkyLightSymbolLoaderto dynamically load private SkyLight APIs, since some symbols are only available on newer macOS versions. Other private API definitions have also been moved intoPrivateApis.swift.