Skip to content

✨ Focus next in stack#929

Merged
mrkai77 merged 2 commits into
developfrom
922-shortcut-to-change-focus-between-front-and-back
Dec 22, 2025
Merged

✨ Focus next in stack#929
mrkai77 merged 2 commits into
developfrom
922-shortcut-to-change-focus-between-front-and-back

Conversation

@mrkai77
Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 commented Dec 22, 2025

  • Adds new function to focus the next window in a stacked configuration.
  • Introduces a new NavigationDirection enum for use in DirectionalNavigationUtility, as leading and trailing do not stay consistent between LTR and RTL layouts.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new function to focus the next window in a stacked configuration and introduces a NavigationDirection enum to replace Edge for directional navigation. This change ensures consistent behavior between LTR (left-to-right) and RTL (right-to-left) layouts.

  • Introduces a new NavigationDirection enum with absolute directions (.left, .right, .top, .bottom) instead of layout-dependent directions (.leading, .trailing)
  • Adds cycleInStack function to the DirectionalNavigationUtility for cycling through overlapping windows
  • Updates API signatures from edge: Edge to direction: NavigationDirection throughout the codebase

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

File Description
Loop/Utilities/DirectionalNavigationUtility.swift Introduces NavigationDirection enum, adds cycleInStack function for stacked window navigation, renames parameters for clarity, and adds filterItemsBySharedArea helper function
Loop/Utilities/ScreenUtility.swift Updates directionalScreen function signature to use NavigationDirection instead of Edge, and updates parameter names
Loop/Core/LoopManager.swift Updates screen and window focus navigation calls to use NavigationDirection, adds handling for focusNextInStack action
Loop/Localizable.xcstrings Adds localization string for "Focus Next In Stack" window action

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Loop/Utilities/DirectionalNavigationUtility.swift Outdated
Comment thread Loop/Utilities/DirectionalNavigationUtility.swift Outdated
Comment thread Loop/Utilities/DirectionalNavigationUtility.swift
Comment thread Loop/Utilities/DirectionalNavigationUtility.swift Outdated
Comment thread Loop/Utilities/DirectionalNavigationUtility.swift Outdated
Comment thread Loop/Utilities/DirectionalNavigationUtility.swift Outdated
Comment thread Loop/Utilities/DirectionalNavigationUtility.swift Outdated
@mrkai77 mrkai77 force-pushed the 922-shortcut-to-change-focus-between-front-and-back branch from 08dc7cd to e67a86c Compare December 22, 2025 21:22
@mrkai77 mrkai77 force-pushed the 922-shortcut-to-change-focus-between-front-and-back branch from e67a86c to fbb83b9 Compare December 22, 2025 21:57
@mrkai77 mrkai77 merged commit 77f7b07 into develop Dec 22, 2025
1 check passed
@mrkai77 mrkai77 deleted the 922-shortcut-to-change-focus-between-front-and-back branch December 22, 2025 21:58
@mrkai77 mrkai77 linked an issue Dec 22, 2025 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Shortcut to change focus between front and back

2 participants