✨ Focus next in stack#929
Merged
mrkai77 merged 2 commits intoDec 22, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new function to focus the next window in a stacked configuration and introduces a NavigationDirection enum to replace Edge for directional navigation. This change ensures consistent behavior between LTR (left-to-right) and RTL (right-to-left) layouts.
- Introduces a new
NavigationDirectionenum with absolute directions (.left,.right,.top,.bottom) instead of layout-dependent directions (.leading,.trailing) - Adds
cycleInStackfunction to theDirectionalNavigationUtilityfor cycling through overlapping windows - Updates API signatures from
edge: Edgetodirection: NavigationDirectionthroughout the codebase
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| Loop/Utilities/DirectionalNavigationUtility.swift | Introduces NavigationDirection enum, adds cycleInStack function for stacked window navigation, renames parameters for clarity, and adds filterItemsBySharedArea helper function |
| Loop/Utilities/ScreenUtility.swift | Updates directionalScreen function signature to use NavigationDirection instead of Edge, and updates parameter names |
| Loop/Core/LoopManager.swift | Updates screen and window focus navigation calls to use NavigationDirection, adds handling for focusNextInStack action |
| Loop/Localizable.xcstrings | Adds localization string for "Focus Next In Stack" window action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
08dc7cd to
e67a86c
Compare
e67a86c to
fbb83b9
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leadingandtrailingdo not stay consistent between LTR and RTL layouts.