⚡ Cache system keybinds when processing keypresses#930
Merged
mrkai77 merged 5 commits intoDec 22, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes the performance of keypress processing by caching system keybinds and changing the lookup from O(n) to O(1). The implementation changes the return type of systemKeybinds from an array to a set of sets for constant-time lookups, and introduces a cache that's populated once at startup rather than queried repeatedly.
Key Changes:
- Changed
systemKeybindsreturn type from[Set<CGKeyCode>]toSet<Set<CGKeyCode>>for O(1) lookups - Added caching of system keybinds in
KeybindTriggerto avoid repeated system API calls - Minor optimization to compute
isLoopOpenonce per event instead of multiple times
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Loop/Extensions/CGKeyCode+Extensions.swift | Modified systemKeybinds to return a Set instead of Array for O(1) lookup performance |
| Loop/Core/Observers/KeybindTrigger.swift | Added caching mechanism for system keybinds and optimized isLoopOpen computation to reduce redundant function calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mrkai77
force-pushed
the
925-huge-mouse-input-latency-spikes-when-keyboard-keys-are-pressed
branch
from
33af218 to
910879d
Compare
…keyboard-keys-are-pressed
mrkai77
deleted the
925-huge-mouse-input-latency-spikes-when-keyboard-keys-are-pressed
branch
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Significantly improves performance by treating system keybind fetching as a cached operation rather than repeated lookups. System keybinds are now returned as a Set for O(1) lookup time when checking if pressed keys match a system keybind.