Skip to content

🐞 Don't change action for noSelection actions in rapid succession#951

Merged
mrkai77 merged 1 commit into
developfrom
karabiner-fix
Jan 6, 2026
Merged

🐞 Don't change action for noSelection actions in rapid succession#951
mrkai77 merged 1 commit into
developfrom
karabiner-fix

Conversation

@mrkai77
Copy link
Copy Markdown
Owner

@mrkai77 mrkai77 commented Jan 5, 2026

Previously, when switching to a new action, it used be filtered like this:

if let startingAction {
    changeAction(startingAction, disableHapticFeedback: true)
}

Now that actions aren't optional types, that broke this behavior. the fix is to now filter for noSelection actions, which is the new equivalent for nil actions:

if startingAction.direction != .noSelection {
    changeAction(startingAction, disableHapticFeedback: true)
}

@mrkai77 mrkai77 self-assigned this Jan 5, 2026
@mrkai77 mrkai77 linked an issue Jan 5, 2026 that may be closed by this pull request
4 tasks
@mrkai77 mrkai77 changed the title 🐞 Don't change action if noSelection in rapid succession 🐞 Don't change action for noSelection actions in rapid succession Jan 5, 2026
@mrkai77 mrkai77 added the Bug label Jan 5, 2026
@mrkai77 mrkai77 merged commit 917f412 into develop Jan 6, 2026
1 check passed
@mrkai77 mrkai77 deleted the karabiner-fix branch January 6, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Does not work correctly with Karabiner-Elements

1 participant