Skip to content

🐞 Fix radial menu not correctly showing direction on cycle actions #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrkai77 merged 1 commit into from
Jan 11, 2026
+4 −4
Merged

🐞 Fix radial menu not correctly showing direction on cycle actions #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Loop/Core/LoopManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ extension LoopManager {
// This is only needed because if preview window is moved
// onto a new screen, it needs to receive a window action
previewController.setAction(to: currentAction)
radialMenuController.setAction(to: currentAction)
radialMenuController.setAction(to: currentAction, parent: parentCycleAction)

if let parentCycleAction {
currentAction = newAction
Expand Down Expand Up @@ -401,7 +401,7 @@ extension LoopManager {

Task { @MainActor in
previewController.setAction(to: newAction)
radialMenuController.setAction(to: newAction)
radialMenuController.setAction(to: newAction, parent: parentCycleAction)

if !Defaults[.previewVisibility], let screenToResizeOn, let targetWindow {
WindowEngine.resize(
Expand Down
4 changes: 2 additions & 2 deletions Loop/Window Action Indicators/Radial Menu/RadialMenuController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ final class RadialMenuController {
viewModel?.setWindow(to: newWindow)
}

func setAction(to newAction: WindowAction) {
viewModel?.setAction(to: newAction)
func setAction(to newAction: WindowAction, parent: WindowAction?) {
viewModel?.setAction(to: newAction, parent: parent)

Log.ui("Set action to '\(newAction.description)'", category: .radialMenuController)
}
Expand Down