Speed up recursive directory listing #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkkrp
force-pushed
the
speed-up-recursive-directory-listing
branch
from
a381581 to
1973355
Compare
|
I agree, but I had no idea how poor. Did you do some benchmarking or is it noticeable even without a benchmark? |
|
No, I did not run a benchmark, I just know that appending lists again and again like this is slow, so I corrected it. I can easily imagine that this can get pretty bad on some huge directory tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@harendra-kumar We should have used difference lists here because linked lists are poor performing monoids :-)