Fix #109 #111
Merged
Fix #109 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #109, it was noted that if the final value of the CSV record was empty, then the JSON object's value for that final column would be ',' which was incorrect. This fixes that by checking if the field is empty and conditionally pushes an appropriate value.
…mplied trailing value. * Since there's an implied trailing value if the last character in a line is a comma, we need to append an additional empty value to the splitLine array. Without that additional empty value, the splitLine array is essentially missing the data for the last value in the line since the line parser was previously not taking into account the implied trailing empty value. #109
* When the last character is a field delimiter, the code was capturing that delimiter value in the second to last value. This adjusts the code such that the field delimiter will not be captured in the second to last value. This issue was discovered while testing the fixes for #109.
* Adds tests for #109.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Information
3.4.2I have...