Fix git init issue

[zommerfelds]

Attempt to fix #36

[zommerfelds]

I'm not sure when this message gets printed. Is this for an older version of git? Maybe we should put a comment to describe how to replicate it in a real system.

[mroth]

I wonder if perhaps this is in fact the same message and it just changed text in more recent versions of git. Perhaps a search through the git codebase could tell us that.

[mroth]

Ah yeah, looks like it was changed in git/git@4ddb135

[mroth]

Awesome! Thanks for taking this on.

[zommerfelds]

Does git ever localize this output? (separate issue maybe)

…

On Wed, Mar 21, 2018, 12:52 Matthew Rothenberg ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In commands/status/process_test.go <#37 (comment)>: > @@ -238,6 +238,10 @@ var testCasesExtractBranch = []struct { []byte("## Initial commit on master"), Ah yeah, looks like it was changed in ***@***.*** <git/git@4ddb135> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#37 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABM8TmT2mxbji9CZWUdsL7i7ovYRcp-Sks5tgoUdgaJpZM4Sy779> .

[zommerfelds]

Is there anything left to be done before we can merge this?

[mroth]

Is there anything left to be done before we can merge this?

Sorry for the delay, I was out of the country.

The one thing I was thinking is that this is a case we should probably have an integration test for as well, so we automatically catch it if the language changes again or similar.

[zommerfelds]

Good point. But actually, there is already a test case for it:

  Scenario: Banner shows no changes when in an unchanged git repo
    Given I am in a git repository
    When I successfully run `scmpuff status`
    Then the output should contain "No changes (working directory clean)"

So, currently the tests are not even passing on master with the newer git version. I created a PR below just to demonstrate this on CI: #36

[mroth]

Oh great, I somehow forgot that integration test already existed. This should be ready to be merged then. Thanks so much for your contribution @zommerfelds !