Fix processing issues with very complex changesets#45
Merged
Conversation
This was originally written early in my Go programming days, and as a CLI tool there are a lot of log.Fatals deep in the stack showing for reporting fatal parsing conditions to the user. But, this makes writing new tests a bit more difficult. In preparation for starting to debug the process parsing bugs, extract the error handling to be more library like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this should address #26 #34 and #35 all at once. Only took me two years to get around to really fixing this.
Fixes #26.
Fixes #34.
Fixes #35.