Conversation
simplify things for people who don't want to think about Ruby, and hopefully in the future when we remove it entirely as a dependency for the integration tests.
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the build toolchain to support more up-to-date tools and configurations for 2025. Key changes include:
- Upgrading the Go version and updating associated workflow actions.
- Removing legacy build files (Rakefile and outdated Dockerfiles) in favor of a new Makefile and updated devcontainer configuration.
- Updating dependency versions and documentation to reflect current practices.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Upgraded Go version from 1.18 to 1.24. |
| commands/status/status.go | Improved error output formatting by switching to a formatted string. |
| Rakefile | Removed legacy build file in favor of the new Makefile. |
| Makefile | Introduced as the new build script with tasks for building, testing, and packaging. |
| Gemfile | Updated the Aruba gem version for test dependencies. |
| CONTRIBUTING.md | Revised instructions to reflect the switch from Rakefile to Makefile. |
| .goreleaser.yml | Updated release configuration with comments noting new default behavior. |
| .github/workflows/test-unit.yml | Upgraded Go version and workflow actions (checkout and setup-go). |
| .github/workflows/test-integration.yml | Updated Go and Ruby versions, and updated build commands from rake to make. |
| .github/workflows/release.yml | Upgraded Go version and updated goreleaser action version and arguments. |
| .github/dependabot.yml | Added dependency updates for the devcontainers package ecosystem. |
| .devcontainer/devcontainer.json | Updated configuration to use a Go dev container with new features and mounts. |
| .devcontainer/base.Dockerfile | Removed legacy base Dockerfile. |
| .devcontainer/Dockerfile | Removed legacy Dockerfile in favor of the updated devcontainer.json configuration. |
also remove the name constant since we weren't really using it consistently, so avoid creating false assumptions.
mroth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor updates to build toolchain to support more up-to-date tool versions.