🐛 Crash during qrcode scanning

[freeboub]

What's happening?

I don't have reproduction way... I just know it happens to our QA and got the sentry report.
May not be linked to qr code scanner, just due to focus management

here is the callstack:

capture/focus-canceled The focus operation has been canceled by a new focus request.
mechanism
onunhandledrejection
handled
true

native in construct
native in apply
/node_modules/@babel/runtime/helpers/construct.js in _construct at line 4:65
/node_modules/@babel/runtime/helpers/wrapNativeSuper.js in Wrapper at line 15:14
native in construct
app:///index.android.bundle in _callSuper at line 232:2
/node_modules/react-native-vision-camera/src/CameraError.ts in constructor at line 155:5

native in construct
app:///index.android.bundle in _callSuper at line 232:2
/node_modules/react-native-vision-camera/src/CameraError.ts in <global> at line 175:32
/node_modules/react-native-vision-camera/src/CameraError.ts in tryParseNativeCameraError at line 220:36
/node_modules/react-native-vision-camera/src/Camera.tsx in focus at line 380:38

Reproduceable Code

N/A

Relevant log output

provided in description

Camera Device

I don't have the device, so I cannot provide the output, but I know it is a 
Pixel 8a

Device

Pixel 8a

VisionCamera Version

4.6.4

Can you reproduce this issue in the VisionCamera Example app?

No, I cannot reproduce the issue in the Example app

Additional information

• I am using Expo
• I have enabled Frame Processors (react-native-worklets-core)
• I have read the Troubleshooting Guide
• I agree to follow this project's Code of Conduct
• I searched for similar issues in this repository and found none.

[maintenance-hans]

Guten Tag, Hans here!

Thanks for your issue report on ze crash during QR code scanning. However, I see that ze provided information is not sufficient to help mrousavy. We need a clearer reproduction step and specific logs from ze device to pinpoint ze issue.

Please gather logs using adb logcat for your Pixel 8a while reproducing ze issue, and include any details you can about any actions that lead to ze crash. This will help us a lot in resolving ze problem!

If you enjoy using ze library, consider supporting mrousavy by sponsoring him here so we can continue improving it. 🍻

Note: If you think I made a mistake, please ping @mrousavy to take a look.

[freeboub]

I did an analyze of the issue, here is the point:

CameraSession.focus can throw an exception which is never catched.

react-native-vision-camera/package/android/src/main/java/com/mrousavy/camera/core/CameraSession+Focus.kt

Line 11 in b982eca

suspend fun CameraSession.focus(meteringPoint: MeteringPoint) {

This function is called only in CameraView.focus :

react-native-vision-camera/package/android/src/main/java/com/mrousavy/camera/react/CameraView+Focus.kt

Line 18 in b982eca

cameraSession.focus(point)

And CameraView.focus is called only from api call:

@ReactMethod
  fun focus(viewTag: Int, point: ReadableMap, promise: Promise) {
    backgroundCoroutineScope.launch {
      val view = findCameraView(viewTag)
      withPromise(promise) {
        view.focus(point)
        return@withPromise null
      }
    }
  }

Would following patch acceptable / enough for you ?

diff --git a/package/android/src/main/java/com/mrousavy/camera/react/CameraView+Focus.kt b/package/android/src/main/java/com/mrousavy/camera/react/CameraView+Focus.kt
index a9d56830..acea411e 100644
--- a/package/android/src/main/java/com/mrousavy/camera/react/CameraView+Focus.kt
+++ b/package/android/src/main/java/com/mrousavy/camera/react/CameraView+Focus.kt
@@ -15,5 +15,5 @@ suspend fun CameraView.focus(pointMap: ReadableMap) {
     val dp = Resources.getSystem().displayMetrics.density
     previewView.meteringPointFactory.createPoint(x.toFloat() * dp, y.toFloat() * dp)
   }
-  cameraSession.focus(point)
+  try {
+    cameraSession.focus(point)
+  } catch (e: Exception) {}
 }

I can open a pull request of course !

[freeboub]

PR rejected, the good solution is to handle correctly exception on app side

[tdammy92]

@freeboub does this fix completely solve your issue ? a device is experiencing this same issue on my app on the device Xiaomi Redmi. recording video on the device is just a dark screen with this same exact error.

[freeboub]

@freeboub does this fix completely solve your issue ? a device is experiencing this same issue on my app on the device Xiaomi Redmi. recording video on the device is just a dark screen with this same exact error.

Yes I confirm it fixes the issue !