Skip to content

Remove "Latest News" column#14

Merged
matz merged 2 commits intomruby:masterfrom
rmosolgo:remove-layout-column
Apr 2, 2015
Merged

Remove "Latest News" column#14
matz merged 2 commits intomruby:masterfrom
rmosolgo:remove-layout-column

Conversation

@rmosolgo
Copy link
Copy Markdown
Contributor

With only one item in the "Latest News" column, I don't think it's worth putting on every page. Here's what I did:

  • Make default layout full width (then, use default for home page & remove home layout)
  • move Latest News into an _include, include it on / and /about
  • Use Bootstrap built-ins to style Latest News items

full width example:

image

One nice thing about using bootstrap built-ins is that it brings items into alignment, for example,

before
image

after
image

Is this an acceptable change? I understand if you prefer not to change it!

@suzukaze
Copy link
Copy Markdown
Contributor

suzukaze commented Apr 2, 2015

This PR is good.
👍

Before:
There is latest news below top page.
There is latest news in right side of Downloads, Libraries and About.

After:
There is latest news below top page and About.

matz added a commit that referenced this pull request Apr 2, 2015
@matz matz merged commit be1e1e5 into mruby:master Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants