Skip to content

Fix allocation-error-handlings for scope_new().#2547

Merged
matz merged 1 commit intomruby:masterfrom
cubicdaiya:issues/scope_new_error_handlings
Aug 20, 2014
Merged

Fix allocation-error-handlings for scope_new().#2547
matz merged 1 commit intomruby:masterfrom
cubicdaiya:issues/scope_new_error_handlings

Conversation

@cubicdaiya
Copy link
Copy Markdown
Contributor

No description provided.

@matz matz merged commit ae2d498 into mruby:master Aug 20, 2014
@cubicdaiya cubicdaiya deleted the issues/scope_new_error_handlings branch August 25, 2014 02:38
Comment thread src/codegen.c
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first argument s of raise_error must not be NULL because it uses s->mrb. https://github.com/mruby/mruby/blob/master/src/codegen.c#L1080

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed in 05ede52

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ghost pushed a commit to iij/mruby that referenced this pull request Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants