Skip to content

Conversation

@mrunalp
Copy link
Owner

@mrunalp mrunalp commented Nov 23, 2015

Signed-off-by: Mrunal Patel mrunalp@gmail.com

@mrunalp
Copy link
Owner Author

mrunalp commented Nov 23, 2015

@rhatdan I tested this on F23. PTAL.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp
Copy link
Owner Author

mrunalp commented Nov 23, 2015

@rhatdan I added man page, update README.md and added the docs to the spec file.

@rhatdan
Copy link
Contributor

rhatdan commented Nov 24, 2015

rpmlint oci_systemd_hook.spec 
oci_systemd_hook.spec: E: specfile-error warning: bogus date in %changelog: Mon Nov 22 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1.2
oci_systemd_hook.spec: E: specfile-error warning: bogus date in %changelog: Mon Nov 22 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1.3
oci_systemd_hook.spec: E: specfile-error warning: bogus date in %changelog: Mon Nov 22 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1.2
0 packages and 1 specfiles checked; 3 errors, 0 warnings.

@rhatdan
Copy link
Contributor

rhatdan commented Nov 24, 2015

make dist builds
oci-systemd-hook-0.1.tar.gz
But
rpmbuild -bs oci_systemd_hook.spec
error: File /home/dwalsh/sources/SOURCES/v0.1.3.tar.gz: No such file or directory

Those should match.

@rhatdan
Copy link
Contributor

rhatdan commented Nov 24, 2015

diff --git a/configure.ac b/configure.ac
index 2565b6c..9232ef5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,4 +1,4 @@
-AC_INIT([OCI Systemd Hook], 0.1)
+AC_INIT([OCI Systemd Hook], 0.1.3)
 AC_CONFIG_AUX_DIR([build-aux])
 AC_CONFIG_HEADERS([config.h])
 AM_INIT_AUTOMAKE([foreign -Wall -Werror subdir-objects])
diff --git a/oci_systemd_hook.spec b/oci_systemd_hook.spec
index 7428e34..2659c33 100644
--- a/oci_systemd_hook.spec
+++ b/oci_systemd_hook.spec
@@ -5,7 +5,7 @@ Summary:        OCI systemd hook for docker
 Group:          Applications/Text
 License:        GPLv3+
 URL:            https://github.com/mrunalp/hooks
-Source:         https://github.com/mrunalp/hooks/archive/v%{version}.tar.gz
+Source:         https://github.com/mrunalp/hooks/archive/%{name}-%{version}.tar.gz

 BuildRequires:  autoconf
 BuildRequires:  automake
@@ -34,9 +34,9 @@ make %{?_smp_mflags}
 %doc README.md LICENSE

 %changelog
-* Mon Nov 22 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1.2
+* Mon Nov 23 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1.3
 - Fix bug in man page installation
-* Mon Nov 22 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1.3
+* Mon Nov 23 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1.2
 - Add man pages
-* Mon Nov 22 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1.2
+* Mon Nov 23 2015 Mrunal Patel <mrunalp@gmail.com> - 0.1-1
 - Initial RPM release

@mrunalp
Copy link
Owner Author

mrunalp commented Nov 24, 2015

The naming weirdness is partly due to repo name being hooks. I will fix that.

Sent from my iPhone

On Nov 24, 2015, at 5:29 AM, Daniel J Walsh notifications@github.com wrote:

make dist builds
oci-systemd-hook-0.1.tar.gz
But
rpmbuild -bs oci_systemd_hook.spec
error: File /home/dwalsh/sources/SOURCES/v0.1.3.tar.gz: No such file or directory

Those should match.


Reply to this email directly or view it on GitHub.

* Fixed description
* Changed version in Makefile.am
* Include README/LICENSE in make dist
* Fix dates in changelog
* Rename spec file to use - instead of _

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp
Copy link
Owner Author

mrunalp commented Nov 24, 2015

@rhatdan I have addressed the comments. Also, renamed the package to have - in name instead of _ so that it works with make dist.

@rhatdan
Copy link
Contributor

rhatdan commented Nov 24, 2015

LGTM. Now you get to start doing the hard part. Working it through the Fedora process.

BTW have you ever looked into the /proc/fs/cgroup problems?

@mrunalp
Copy link
Owner Author

mrunalp commented Nov 24, 2015

@rhatdan Thanks for the review. Agree that is going to be the hardest 😆
I did spend some time but it isn't done. I will get back to looking into the cgroups mounting.

mrunalp pushed a commit that referenced this pull request Nov 24, 2015
@mrunalp mrunalp merged commit 689ea6c into master Nov 24, 2015
mrunalp pushed a commit that referenced this pull request Jul 26, 2016
Build on CentOS7 (Project Atomic C7 Continuous rdgo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants