feat(secrets): system secrets management (#1417)#1419
Merged
mrveiss merged 1 commit intoDev_new_guifrom Mar 6, 2026
Merged
Conversation
- Add SystemSecret model with AES-256-GCM encrypted values
- Add CRUD API at /api/secrets (admin-only, values never returned in list)
- Add /api/secrets/{key}/value endpoint for fleet provisioning
- Add SecretsSettings.vue admin page with create/update/delete UI
- Add useSecretsApi composable for frontend API integration
- Register secrets route in settings navigation
|
| Metric | Count |
|---|---|
| Total Violations | 371 |
| SSOT Violations (high priority) | 286 |
| Other Violations | 85 |
⚠️ 286 values have SSOT config equivalents!
These should be replaced with SSOT config imports:
Python:
from src.config.ssot_config import config
# Use: config.vm.main, config.port.backend, config.backend_urlTypeScript:
import config from '@/config/ssot-config'
// Use: config.vm.main, config.port.backend, config.backendUrl📖 See SSOT_CONFIG_GUIDE.md for documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SystemSecretmodel with AES-256-GCM encrypted value storage/api/secrets(values never returned in list/get responses)/api/secrets/{key}/valueendpoint for fleet provisioning (admin-only decryption)SecretsSettings.vueadmin page in Settings > Secrets with create/update/delete UIuseSecretsApicomposable for frontend API integrationArchitecture
services/encryption.py(AES-256-GCM + PBKDF2)/valueendpointTest Plan
/settings/admin/secrets/api/secretsCloses #1417