chore(docs): worktree --unset-upstream to prevent PR bypass (#1695)#1698
Merged
mrveiss merged 1 commit intoDev_new_guifrom Mar 14, 2026
Merged
chore(docs): worktree --unset-upstream to prevent PR bypass (#1695)#1698mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…1695) Worktree branches created with `origin/Dev_new_gui` as start-point automatically track upstream. If another session merges work that fast-forwards past the worktree commit, it lands on Dev_new_gui without a PR. Adding `git branch --unset-upstream` after worktree creation prevents this.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git branch --unset-upstreamto the worktree creation instructions in CLAUDE.mdorigin/Dev_new_guidirectly, which can cause commits to land on Dev_new_gui via fast-forward merge without going through a PRRoot cause
When
git worktree add -b <branch> origin/Dev_new_guicreates a branch, it automatically sets upstream tracking toorigin/Dev_new_gui. If another session rebases or fast-forwards Dev_new_gui past the worktree's commit, the commit bypasses code review.Retroactive review
Commit
e4517859b(the direct push that prompted this issue) was reviewed:auto-close-issues.yml(text-only, workflow rename + comment-only behavior),CLAUDE.md(ritual text update)Closes #1695
Test plan
--unset-upstreamcommand