fix(logs): preserve subdirectory components in _validate_log_path (#2194)#2283
Closed
mrveiss wants to merge 1 commit intoDev_new_guifrom
Closed
fix(logs): preserve subdirectory components in _validate_log_path (#2194)#2283mrveiss wants to merge 1 commit intoDev_new_guifrom
mrveiss wants to merge 1 commit intoDev_new_guifrom
Conversation
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
Owner
Author
|
Closing in favor of PR #2285 which uses a cleaner approach (fixes callers + validator together). |
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validate_log_pathwhich usedPath(file_path).name, silently dropping subdirectory componentsbackend/app.logwas resolving toapp.loginstead ofLOG_DIR/backend/app.logvalidate_relative_pathTest plan
backend/app.log→LOG_DIR/backend/app.logLOG_DIR/backend/app.log→ strips prefix correctly../etc/passwd→ errorCloses #2194
🤖 Generated with Claude Code