refactor(backend): decompose _generate_dynamic_inventory into 5 helpers (#2823)#2945
Merged
mrveiss merged 1 commit intoDev_new_guifrom Mar 30, 2026
Merged
refactor(backend): decompose _generate_dynamic_inventory into 5 helpers (#2823)#2945mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…rs (#2823) Extract Method refactoring — zero behavior change: - _build_host_entries: host dict from DB nodes (27 lines) - _apply_role_host_vars: stamp roles/deps onto hosts (30 lines) - _apply_colocation_vars: frontend/backend co-location (25 lines) - _build_inventory_dict: assemble top-level structure (29 lines) - _fetch_inventory_data: async DB queries + sync helpers (44 lines) Main function reduced from 153 to 25 lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
| Metric | Count |
|---|---|
| Total Violations | 3 |
| SSOT Violations (high priority) | 2 |
| Other Violations | 1 |
⚠️ 2 values have SSOT config equivalents!
These should be replaced with SSOT config imports:
Python:
from src.config.ssot_config import config
# Use: config.vm.main, config.port.backend, config.backend_urlTypeScript:
import config from '@/config/ssot-config'
// Use: config.vm.main, config.port.backend, config.backendUrl📖 See SSOT_CONFIG_GUIDE.md for documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract Method refactoring of 153-line function into 5 focused helpers:
_build_host_entries(27 lines),_apply_role_host_vars(30),_apply_colocation_vars(25),_build_inventory_dict(29),_fetch_inventory_data(44)Closes #2823
🤖 Generated with Claude Code