fix(chat): resolve run_in_chat_io_executor keyword argument mismatch (#2958)#2964
Merged
mrveiss merged 2 commits intoDev_new_guifrom Mar 31, 2026
Merged
fix(chat): resolve run_in_chat_io_executor keyword argument mismatch (#2958)#2964mrveiss merged 2 commits intoDev_new_guifrom
mrveiss merged 2 commits intoDev_new_guifrom
Conversation
…2958) run_in_chat_io_executor() wraps loop.run_in_executor() which only accepts fn and *args — keyword arguments are not forwarded. Updated the executor to accept **kwargs and bind them via functools.partial before dispatch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
| Metric | Count |
|---|---|
| Total Violations | 3 |
| SSOT Violations (high priority) | 2 |
| Other Violations | 1 |
⚠️ 2 values have SSOT config equivalents!
These should be replaced with SSOT config imports:
Python:
from src.config.ssot_config import config
# Use: config.vm.main, config.port.backend, config.backend_urlTypeScript:
import config from '@/config/ssot-config'
// Use: config.vm.main, config.port.backend, config.backendUrl📖 See SSOT_CONFIG_GUIDE.md for documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_in_chat_io_executor()wrapsloop.run_in_executor()which doesn't forward kwargs**kwargsand bind them viafunctools.partialbefore dispatchexist_ok=TruekwargCloses #2958
Test plan
unexpected keyword argumenterrors🤖 Generated with Claude Code