fix(hardening): enhance hook to catch single-quoted path literals (#3939)#3968
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 8, 2026
Merged
fix(hardening): enhance hook to catch single-quoted path literals (#3939)#3968mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
) The grep pattern for hardcoded paths used POSIX non-capturing group syntax (?:...) which is not supported in ERE. Updated to standard alternation syntax ["'](...) that works with both single and double quoted strings. Tested: grep now correctly detects both 'path' and "path" literals. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3939
Fixed the pre-commit hook regex to correctly detect both single and double quoted hardcoded path literals.