fix(a2a): correct routing threshold for research and knowledge_retrieval agents (#4530)#4541
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 14, 2026
Merged
fix(a2a): correct routing threshold for research and knowledge_retrieval agents (#4530)#4541mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…#4530) Pattern-match confidence for research/knowledge was exactly 0.8 but the threshold check used strict `> 0.8`, causing both query types to fall through to the LLM router which misrouted them. Changed threshold to `>= 0.8` so these patterns are honoured directly. Also added missing "knowledge base", "in the documents", and "in my documents" phrases to KNOWLEDGE_PATTERNS so queries that explicitly mention the KB are caught without relying on the LLM.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4530
Summary
determine_routing()used strict> 0.8but research and knowledge patterns return confidence exactly0.8, causing fallthrough to the LLM router which misrouted them>= 0.8knowledge base,in the documents,in my documents) toKNOWLEDGE_PATTERNSTest Status
PASS — lint clean
🤖 Generated with Claude Code