fix(kb): add process_query() to KBLibrarianAgent — fixes RAG agent crash (#4531)#4542
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 14, 2026
Merged
fix(kb): add process_query() to KBLibrarianAgent — fixes RAG agent crash (#4531)#4542mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…rs (#4531) KBLibrarianAgent was missing process_query(), enabled, max_results, similarity_threshold, and auto_summarize — all referenced by api/kb_librarian.py, api/workflow.py, and agent_execution.py, causing AttributeError on every KB/RAG query.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4531
Summary
process_query()method toKBLibrarianAgentwrappingsearch_knowledge()and optionallyanswer_question(), returning a dict compatible withKBQueryResponseenabled,max_results,similarity_threshold,auto_summarize) thatapi/kb_librarian.pyreads and temporarily overrides per-requestagent_execution.pyTest Status
FAIL (pre-existing:
llama_indexnot installed in dev env — unrelated to this fix)🤖 Generated with Claude Code