fix(knowledge): validate synthesis_schema source paths on load — warn on missing (#4695)#4714
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 15, 2026
Merged
fix(knowledge): validate synthesis_schema source paths on load — warn on missing (#4695)#4714mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…warning for missing paths (#4695) After parsing each collection, warn (do not raise) for any declared path that does not exist relative to the repo root. Adds repo_root param to load_synthesis_schema() (defaults to __file__-relative root) and threads it through _parse_collection(). Adds 3 tests: existing path → no warning, missing path → warning, mixed list → one warning per missing path.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4695
Summary
load_synthesis_schema()and_parse_collection()now accept optionalrepo_rootparameter (defaults to repo root via__file__)config.pathsand emitslogger.warning(...)for any path that doesn't existTests
🤖 Generated with Claude Code