fix(rag): remove dead NeuralMeshRetriever injection gate from RAGService (#4686)#4715
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 15, 2026
Merged
fix(rag): remove dead NeuralMeshRetriever injection gate from RAGService (#4686)#4715mrveiss merged 1 commit intoDev_new_guifrom
mrveiss merged 1 commit intoDev_new_guifrom
Conversation
…ice (#4686) NeuralMeshRetriever requires 7+ injected dependencies (PPR, EdgeLearner, mesh_db, etc.) that don't exist in any production startup path. Remove _mesh_retriever field, _run_mesh_retriever() method, the guard block in advanced_search(), and mesh_retriever_enabled from RAGConfig.to_dict(). NeuralMeshRetriever class itself is retained — it has its own tests.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4686
Summary
NeuralMeshRetrieverrequires 7+ injected dependencies (PPR, EdgeLearner, mesh_db, etc.) that don't exist in any production startup path_mesh_retrieverfield,_run_mesh_retriever()method, the guard block inadvanced_search(), andmesh_retriever_enabledfromRAGConfig.to_dict()NeuralMeshRetrieverclass itself retained — it has its own testsNote: Commit was from a prior session, worktree accidentally cleaned before push — recovered from git reflog.