Skip to content

fix(testing): patch get_async_redis_client in TestStoreFeedbackInStream (#4720)#4731

Merged
mrveiss merged 1 commit intoDev_new_guifrom
issue-4720
Apr 15, 2026
Merged

fix(testing): patch get_async_redis_client in TestStoreFeedbackInStream (#4720)#4731
mrveiss merged 1 commit intoDev_new_guifrom
issue-4720

Conversation

@mrveiss
Copy link
Copy Markdown
Owner

@mrveiss mrveiss commented Apr 15, 2026

Closes #4720

Summary

  • All 9 patch() calls in TestStoreFeedbackInStream and TestComplexityInStoreFeedbackInStream were targeting services.rag_service.get_redis_client — a name that doesn't exist in the module namespace (rag_service.py imports get_async_redis_client)
  • Fixed all patch targets to services.rag_service.get_async_redis_client
  • Patches were previously no-ops, causing real Redis to be called in tests

Tests

  • All 6 TestStoreFeedbackInStream tests now pass

🤖 Generated with Claude Code

…am — was patching non-existent get_redis_client (#4720)
@mrveiss mrveiss merged commit 758fd20 into Dev_new_gui Apr 15, 2026
3 of 4 checks passed
@mrveiss mrveiss deleted the issue-4720 branch April 15, 2026 18:06
@github-actions
Copy link
Copy Markdown

✅ SSOT Configuration Compliance: Passing

🎉 No hardcoded values detected that have SSOT config equivalents!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant