fix(usage): replace redis.keys() with async scan_iter in cost tracker — eliminates O(N) block (#4443)#4733
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 15, 2026
Merged
Conversation
…_costs, get_all_agent_costs, _fetch_model_costs (#4443) Eliminates O(N) blocking KEYS command across three cost-tracking methods; adds 5 async unit tests verifying scan_iter is called and daily sub-keys are correctly filtered.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4443
Summary
_fetch_model_costs,get_all_agent_costs,get_all_user_costsinllm_cost_tracker.pyall usedawait redis.keys(pattern)— a blocking O(N) call that scans the entire keyspace[k async for k in redis.scan_iter(pattern)]— non-blocking cursor-based iterationall_keysvariable inget_all_user_costs, inlined filter directly into the async comprehension:daily:sub-key filtering behaviour fully preservedTests
TestScanIterUsagetests + 53 pre-existing = 63 passed🤖 Generated with Claude Code