fix(testing): lazy-load BROWSER_TOOL_NAMES import in tool_registry — breaks circular import (#4557)#4734
Merged
mrveiss merged 1 commit intoDev_new_guifrom Apr 15, 2026
Merged
Conversation
…circular import (#4557) Circular import chain: chat_workflow.__init__ → manager → tool_handler → tools (code_interpreter) → tools.__init__ → tool_registry → chat_workflow.tool_handler (partially initialized, ImportError). Fix: remove the module-level `from chat_workflow.tool_handler import BROWSER_TOOL_NAMES` in tool_registry.py and move it inside get_available_tools() as a lazy import. This breaks the cycle while preserving the single-source-of-truth semantics documented in #2609. Result: 262 chat_workflow unit tests now collect and pass.
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4557
Summary
Root cause was a circular import in
tools/tool_registry.py— the module-levelfrom chat_workflow.tool_handler import BROWSER_TOOL_NAMEScreated a cycle:chat_workflow.__init__→manager→tool_handler→tools.__init__→tool_registry→chat_workflow.tool_handler(partially initialized →ImportError).Fix: moved the import inside
get_available_tools()as a lazy import. Single-source-of-truth semantics from #2609 fully preserved — import resolves at call time when both modules are fully initialized.Tests
chat_workflow/tests passprompt_hooks_test.py::test_total_hook_count_increasedasserts 24 HookPoints but finds 25 — unrelated to this change🤖 Generated with Claude Code